Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix for values_list #1442

Merged

Conversation

BradleySappington
Copy link
Collaborator

per django documentation,
values_list should be able to take a single column name ("root_name") with flat=True parameter. This isn't taking in our current situation and is throwing an error sayin '' is not an acceptable field Adding a bogus but existing second column of data resolves the issue. Pushing forward to resolve the bug with this release but can re-evaluate issue with django if priorities permit.

@pep8speaks
Copy link

pep8speaks commented Jan 24, 2024

Hello @BradleySappington, Thank you for updating !

Line 416:13: E128 continuation line under-indented for visual indent
Line 427:17: E128 continuation line under-indented for visual indent

Comment last updated at 2024-01-24 15:36:35 UTC

@BradleySappington
Copy link
Collaborator Author

Copy link
Collaborator

@bhilbert4 bhilbert4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Should we create a new JIRA issue to fix this, and include links to the relevant DJango doc or stackoverflow question?

@BradleySappington
Copy link
Collaborator Author

Looks good to me. Should we create a new JIRA issue to fix this, and include links to the relevant DJango doc or stackoverflow question?

yeah, I think thats a good idea. We are soon going to update to django 5.0. in the next release, so the work should be done after that. It'll be low priority since it at least works this way.

@BradleySappington BradleySappington merged commit b242db2 into spacetelescope:develop Jan 24, 2024
6 checks passed
@BradleySappington BradleySappington deleted the anomaly_bugfix branch January 24, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants