Retrieve program number and category efficiently #1455
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1428
This PR fixes a problem where our MAST query to retrieve program numbers + categories was really inefficient, and was running into the maximum number of rows that MAST would return (even with our increased limit).
With this, get_proposals_by_category() now gets information by querying pyvo, rather than MAST itself. I have confirmed that the dictionary returned with the new function matches that from the old function (and the new function executes many times faster than the old function).
@mfixstsci this is ready for review.