Get subarray lists from datamodels schema #1479
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1389
Rather than relying on manually provided subarray lists (which had been missing some entries), get subarray lists from the subarray schema file in the stdatamodels package. This ensures that all available subarrays will be present on the JWQL query page.
One downside to this is the way the schema file is read in. Since the instrument names are in commented lines in the schema file, the subarray lists are accessed through hard-coded indexing. If the order of the instruments' lists ever change in the schema file, we would need to update this code. That seems pretty unlikely though.
Local testing looks good.