Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more info to image- and exposure-level pages #1489

Merged
merged 9 commits into from
Feb 19, 2024

Conversation

bhilbert4
Copy link
Collaborator

Resolves #1304

Add more information about the current exposure to the image-level and exposure-level pages. In order to try and save space, much of this information is placed in a collapsible text box.

@pep8speaks
Copy link

pep8speaks commented Feb 19, 2024

Hello @bhilbert4, Thank you for updating !

Line 48:1: W293 blank line contains whitespace
Line 203:1: E304 blank lines found after function decorator
Line 342:1: E302 expected 2 blank lines, found 1

Comment last updated at 2024-02-19 22:41:41 UTC

@bhilbert4 bhilbert4 changed the title [WIP]: Add more info to image- and exposure-level pages Add more info to image- and exposure-level pages Feb 19, 2024
@bhilbert4
Copy link
Collaborator Author

@mfixstsci this is ready for review.

@bhilbert4
Copy link
Collaborator Author

@BradleySappington if you're inspired, feel free to give a quick look-over. My css and js updates seem to be doing what I want (after our meeting on Friday), but there was a fair amount of bumbling around to arrive at what works. If you're not inspired though, no problem.

Copy link
Collaborator

@BradleySappington BradleySappington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@mfixstsci mfixstsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bhilbert4 this all looks good. Thanks for your work on this. I remember seeing it in action last week on our huddle. Glad we are able to get this in.

@mfixstsci
Copy link
Collaborator

@bhilbert4 if you could just resolve the conflict in test_data_containers.py we can merge this in.

@bhilbert4
Copy link
Collaborator Author

@bhilbert4 if you could just resolve the conflict in test_data_containers.py we can merge this in.

Done!

@mfixstsci mfixstsci merged commit 31d65f2 into spacetelescope:develop Feb 19, 2024
6 checks passed
@bhilbert4 bhilbert4 deleted the add-info-to-exposure-page branch February 20, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more descriptive information to the image and exposure pages
4 participants