Moved ON_GITHUB_ACTIONS and ON_READTHEDOCS to constants.py #1490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed them wherever they're defined.
|
Hello @york-stsci, Thank you for updating ! Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated at 2024-02-19 19:09:30 UTC |
bhilbert4
reviewed
Feb 19, 2024
There was a problem hiding this comment.
It looks like there are a few files where ON_READTHEDOCS is not used, where these changes now import it. I can't claim to understand why RTD is not failing in these cases (maybe RTD does not look at unit test files?), but if we don't need ON_READTHEDOCS, then we shouldn't import it.
mfixstsci
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
Thank you @york-stsci easy to review, hope it wasn't too hard to find all of the instances of ON_GITHUB_ACTIONS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added import statements as needed.