Fix Broken Dashboard - ReImplement Anomaly Dash

[BradleySappington]

Fix broken dashboard due to references to unused anomaly tables
Re write anomaly dashboard functionality to use new table structure.

[pep8speaks]

Hello @BradleySappington, Thank you for updating !

• In the file jwql/edb/engineering_database.py:

Line 533:25: E226 missing whitespace around arithmetic operator
Line 534:24: E226 missing whitespace around arithmetic operator
Line 682:17: E126 continuation line over-indented for hanging indent

• In the file jwql/instrument_monitors/common_monitors/edb_telemetry_monitor.py:

Line 995:13: E128 continuation line under-indented for visual indent
Line 1001:41: E128 continuation line under-indented for visual indent
Line 1142:17: E128 continuation line under-indented for visual indent
Line 1150:17: E128 continuation line under-indented for visual indent

• In the file jwql/tests/test_data_containers.py:

Line 288:1: E302 expected 2 blank lines, found 1

• In the file jwql/website/apps/jwql/bokeh_dashboard.py:

Line 228:83: E231 missing whitespace after ','

• In the file jwql/website/apps/jwql/monitor_pages/monitor_bias_bokeh.py:

Line 138:16: E124 closing bracket does not match visual indentation
Line 151:64: E502 the backslash is redundant between brackets
Line 153:17: E124 closing bracket does not match visual indentation

• In the file jwql/website/apps/jwql/monitor_pages/monitor_dark_bokeh.py:

Line 685:38: E124 closing bracket does not match visual indentation

Comment last updated at 2024-02-19 21:44:25 UTC

[york-stsci]

Is it worth changing any of the database queries that use database_interface to use the django models instead?

[bhilbert4]

I haven't tried looking at the dashboard yet, but LGTM code-wise.

[bhilbert4]

The page looks about as good as it can get when running locally.

[BradleySappington]

Is it worth changing any of the database queries that use database_interface to use the django models instead?

@york-stsci
I considered this and chose not to just because they will continue working with their current setup and I wanted to get the dashboard functional again. We can discuss if its worth the time commitment to have django do them, and if so, can have it be part of the epic of the migration to the model system.

[york-stsci]

Ultimately, at the end of the epic, the database_interface code will have been removed, so the answer for "is it worth the time commitment" is going to be "yes" eventually, but it certainly doesn't need to be a part of this PR specifically.

[BradleySappington]

Well that makes that decision easy :)