Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create pull_jwql_branch.sh #1494

Merged

Conversation

BradleySappington
Copy link
Collaborator

@BradleySappington BradleySappington commented Feb 20, 2024

create a bash script that will automate pulling new branches or updating current ones.
This is intended to be used during our release procedure but can also be used for devs to verify that their migrations are up to date when pulling from develop.

@BradleySappington BradleySappington self-assigned this Feb 20, 2024
@BradleySappington BradleySappington marked this pull request as ready for review February 20, 2024 20:57
@BradleySappington
Copy link
Collaborator Author

@bhilbert4 @mfixstsci @york-stsci - This is the adaptable script that we were using for releases. Now with some options handle via parameters so it can be used for local development. Do you think anything else would be handy to add? If not review appreciated.

@mfixstsci
Copy link
Collaborator

Personally, since I have the least experience with django migrations, anything to make the process more streamlined and less prone to error is extremely useful. Let me take a look 👍

Copy link
Collaborator

@mfixstsci mfixstsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BradleySappington this is great and I think it's useful. Before approving I will see what the others think.

jwql/pull_jwql_branch.sh Show resolved Hide resolved
jwql/pull_jwql_branch.sh Show resolved Hide resolved
@mfixstsci
Copy link
Collaborator

Another question @BradleySappington do I need to be in a specific branch when running this script? Would there be any harm if someone were to set branch_name to develop? I know these branches are local to a user's forked repo (so do whatever man, it's your life) but I just wanted to double check on the implications that it could have for conflicts etc etc

@BradleySappington
Copy link
Collaborator Author

@mfixstsci - if you are in develop and run this, there will just be a harmless failure on the checkouts that can be ignored

@york-stsci
Copy link
Collaborator

I have only a tiny comment – in the "echo_format" function, could you add a line explaining what "reset service" means? I'm guessing it means running "systemctl restart jwql" but I'm not quite sure.

@BradleySappington
Copy link
Collaborator Author

@york-stsci - NP, I added the full set of usage instructions to echo_format.

Copy link
Collaborator

@bhilbert4 bhilbert4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slick. Looks like this will make the release process easier.

jwql/pull_jwql_branch.sh Show resolved Hide resolved
jwql/pull_jwql_branch.sh Show resolved Hide resolved
@york-stsci
Copy link
Collaborator

@BradleySappington Thank you, and looks good to me.

Copy link
Collaborator

@york-stsci york-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a very useful script

@mfixstsci
Copy link
Collaborator

@BradleySappington looks like everyone is in support! Once all the conversations are resolved, I am okay with merging!

@BradleySappington BradleySappington merged commit 4d60962 into spacetelescope:develop Feb 21, 2024
6 checks passed
@BradleySappington BradleySappington deleted the pull_jwql_branch branch February 21, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants