-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create pull_jwql_branch.sh #1494
create pull_jwql_branch.sh #1494
Conversation
@bhilbert4 @mfixstsci @york-stsci - This is the adaptable script that we were using for releases. Now with some options handle via parameters so it can be used for local development. Do you think anything else would be handy to add? If not review appreciated. |
Personally, since I have the least experience with django migrations, anything to make the process more streamlined and less prone to error is extremely useful. Let me take a look 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BradleySappington this is great and I think it's useful. Before approving I will see what the others think.
Another question @BradleySappington do I need to be in a specific branch when running this script? Would there be any harm if someone were to set |
@mfixstsci - if you are in develop and run this, there will just be a harmless failure on the checkouts that can be ignored |
I have only a tiny comment – in the "echo_format" function, could you add a line explaining what "reset service" means? I'm guessing it means running "systemctl restart jwql" but I'm not quite sure. |
@york-stsci - NP, I added the full set of usage instructions to echo_format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slick. Looks like this will make the release process easier.
@BradleySappington Thank you, and looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a very useful script
@BradleySappington looks like everyone is in support! Once all the conversations are resolved, I am okay with merging! |
create a bash script that will automate pulling new branches or updating current ones.
This is intended to be used during our release procedure but can also be used for devs to verify that their migrations are up to date when pulling from develop.