Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Bad Pixel Monitor to use Django DB Models #1497

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Update Bad Pixel Monitor to use Django DB Models #1497

wants to merge 7 commits into from

Conversation

mfixstsci
Copy link
Collaborator

No description provided.

@pep8speaks
Copy link

pep8speaks commented Mar 11, 2024 •
edited

Hello @mfixstsci, Thank you for updating !

Line 284:62: W291 trailing whitespace
Line 288:25: E127 continuation line over-indented for visual indent

Comment last updated at 2024-04-25 16:42:45 UTC

@mfixstsci mfixstsci changed the title WIP Update Bad Pixel Monitor to use Django DB Models Update Bad Pixel Monitor to use Django DB Models Mar 11, 2024
bhilbert4
bhilbert4 reviewed Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@bhilbert4 bhilbert4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me. What about in monitor_bad_pixel_bokeh.py? That should be querying the database in order to produce the plots, right?

@mfixstsci
Copy link
Collaborator Author

These changes look good to me. What about in monitor_bad_pixel_bokeh.py? That should be querying the database in order to produce the plots, right?

@bhilbert4 you are right, I just looked at the file. I will go ahead and update it.

@mfixstsci
Copy link
Collaborator Author

@bhilbert4 okay, so the updates to monitor_bad_pixel_bokeh.py are in. I think should do it, let me know if I missed anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhilbert4 bhilbert4 bhilbert4 left review comments

@BradleySappington BradleySappington Awaiting requested review from BradleySappington

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mfixstsci @pep8speaks @bhilbert4