Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Redis Package Names in Environment Files #1546

Merged
merged 7 commits into from Apr 25, 2024

Conversation

mfixstsci
Copy link
Collaborator

No description provided.

@mfixstsci
Copy link
Collaborator Author

@BradleySappington So the python-3.9/osx build is failing because of the astropy dependency requirements to bump up to python 3.10. Want to remove python 3.9 env in this PR? We can then remove the test requirement in the settings as well.

@mfixstsci
Copy link
Collaborator Author

@BradleySappington @bhilbert4 there is something going on with the command conda with the new mamba action we are using. @zacharyburnett I removed the line and the tests pass now 🤷‍♂️ I think keeping track of what our dependencies look like when running the tests is important but am curious why conda export env and mamba export env are not working.

@mfixstsci
Copy link
Collaborator Author

@BradleySappington @bhilbert4 there is something going on with the command conda with the new mamba action we are using. @zacharyburnett I removed the line and the tests pass now 🤷‍♂️ I think keeping track of what our dependencies look like when running the tests is important but am curious why conda export env and mamba export env are not working.

Looks like we needed micromamba instead of conda or mamba in the export statement. Looks good now 👍

Copy link
Collaborator

@BradleySappington BradleySappington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mfixstsci mfixstsci merged commit ab5532a into spacetelescope:develop Apr 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants