Add keyword to specify program IDs for preview image creation #1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was inspired by #1592 where is seems like eventually we'll want to replace all preview images. |
|
@mfixstsci this is also ready for review. Local testing showed no problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an optional "programs" keyword to generate_preview_images.py. This allows the user to specify a list of program ID numbers (e.g. 1068, 01220) to the call to generate_preview_images.py. If this keyword is given, the script will create preview images only for the specified programs. If no program keyword is given the script will create preview images for all programs, as it did previously.
With this new keyword, we can split up the creation of new preview images into multiple calls (on multiple machines), and speed up the creation of new preview images. Or, if we find we need to update the preview images for only a few, specific programs, this will allow us to do that.