Reduce memory usage by the dark monitor #908
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes adjustments to the dark current monitor in order to try and reduce the overall memory usage. I'm afraid there isn't much we can do here. The highest memory usage comes when running the cal pipeline on the input files.
One option would be to skip the cal pipeline and fall back to using (last group - first group) as an approximation of the slope image.
Look into what effects using the difference image would make.Would CRs throw off the statistics since we'd be skipping the jump stepWould the dark rate histograms still be usefulThis is being done as part of the effort to resolve #905