Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce memory usage by the dark monitor #908

Merged
merged 4 commits into from
Jun 10, 2022

Conversation

bhilbert4
Copy link
Collaborator

@bhilbert4 bhilbert4 commented Mar 25, 2022

This PR makes adjustments to the dark current monitor in order to try and reduce the overall memory usage. I'm afraid there isn't much we can do here. The highest memory usage comes when running the cal pipeline on the input files.

One option would be to skip the cal pipeline and fall back to using (last group - first group) as an approximation of the slope image.

  • Look into what effects using the difference image would make.
  • Would CRs throw off the statistics since we'd be skipping the jump step
  • Would the dark rate histograms still be useful

This is being done as part of the effort to resolve #905

@bhilbert4 bhilbert4 self-assigned this Mar 25, 2022
@pep8speaks
Copy link

pep8speaks commented Mar 25, 2022

Hello @bhilbert4, Thank you for updating !

Line 81:34: E126 continuation line over-indented for hanging indent
Line 387:31: E127 continuation line over-indented for visual indent
Line 387:67: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 797:39: E127 continuation line over-indented for visual indent

Comment last updated at 2022-06-03 15:19:57 UTC

@bhilbert4 bhilbert4 changed the title Reduce memory usage by the dark monitor [WIP]: Reduce memory usage by the dark monitor Mar 28, 2022
@bhilbert4 bhilbert4 changed the title [WIP]: Reduce memory usage by the dark monitor Reduce memory usage by the dark monitor Jun 3, 2022
@bhilbert4
Copy link
Collaborator Author

I think this is all we can really do for now. I think we should review and merge this, and hopefully #921 will take care of residual memory errors.

@bhilbert4 bhilbert4 requested a review from mfixstsci June 3, 2022 15:21
@mfixstsci mfixstsci merged commit cda0dcc into spacetelescope:develop Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing monitors - probably due to memory issues with large files
3 participants