Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove savefig overwrite call to avoid future deprecation error #937

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

bsunnquist
Copy link
Collaborator

This PR addresses #904 . It simply removes the overwrite call when saving figures in the readnoise monitor to avoid a future deprecation error. This is the only place I see this argument in our code base.

@bsunnquist bsunnquist self-assigned this Apr 21, 2022
@pep8speaks
Copy link

Hello @bsunnquist, Thank you for submitting the Pull Request !

Line 47:1: E402 module level import not at top of file
Line 48:1: E402 module level import not at top of file
Line 49:1: E402 module level import not at top of file
Line 50:1: E402 module level import not at top of file
Line 52:1: E402 module level import not at top of file
Line 53:1: E402 module level import not at top of file
Line 54:1: E402 module level import not at top of file
Line 55:1: E402 module level import not at top of file
Line 56:1: E402 module level import not at top of file
Line 57:1: E402 module level import not at top of file
Line 58:1: E402 module level import not at top of file
Line 59:1: E402 module level import not at top of file
Line 60:1: E402 module level import not at top of file
Line 61:1: E402 module level import not at top of file
Line 62:1: E402 module level import not at top of file
Line 63:1: E402 module level import not at top of file
Line 64:1: E402 module level import not at top of file
Line 357:61: E226 missing whitespace around arithmetic operator
Line 357:110: E226 missing whitespace around arithmetic operator
Line 360:61: E226 missing whitespace around arithmetic operator
Line 360:110: E226 missing whitespace around arithmetic operator
Line 372:33: E226 missing whitespace around arithmetic operator
Line 389:13: E128 continuation line under-indented for visual indent
Line 389:42: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 424:13: E722 do not use bare 'except'
Line 460:13: E722 do not use bare 'except'
Line 608:67: E226 missing whitespace around arithmetic operator
Line 608:70: E226 missing whitespace around arithmetic operator
Line 610:66: E226 missing whitespace around arithmetic operator

If you have not done so, please consult the jwql Style Guide

Copy link
Collaborator

@mfixstsci mfixstsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this @bsunnquist LGTM

@mfixstsci mfixstsci merged commit 1b332dd into spacetelescope:develop Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

matplotlib savefig overwrite keyword is deprecated
3 participants