-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn off thumbnail creation for all but rate files #968
Turn off thumbnail creation for all but rate files #968
Conversation
Hello @bhilbert4, Thank you for updating !
Comment last updated at 2022-07-22 16:53:08 UTC |
|
Interested to hear what @BradleySappington thinks of these changes, since he's spent a lot of time recently looking at preview/thumbnail image generation. |
This looks good with the understanding that the dark files will not be created until the third task is completed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, would hold off on merge until dark code is included.
First test on the dev server failed due to a typo in the filename to save the thumbnails to. Typo has been fixed in the latest commit, and this is ready for re-testing on the dev server. Concentrate on program 1062, whose thumbnails I removed. |
Tested on the test server. The code successfully made thumbnail files only for rate and dark files, as expected. I then tested and these new thumbnail images were successfully displayed on pages for individual programs. @mfixstsci I think this is ready for review. Once this is in, I think we'll be in good shape to regenerate thumbnails on the ops server. |
Ah sorry, I forgot that @BradleySappington reviewed this earlier. Either one or both of you are welcome to check the latest updates. |
@BradleySappington would you like to do the honors and merge it? |
yessir! |
Thanks! |
@mfixstsci I currently lack authorization to merge |
That's okay @BradleySappington, the branch was stale so we had to merge all of our recent updates into this branch. Once the tests pass, send it. |
Tests passed, but merging is blocked because I'm not authorized. This is a "protected branch" |
Resolves #957
This PR makes changes to the preview image generation code such that thumbnail images are created only for rate files. Currently we are creating thumbnail files for all file types (uncal, rate, cal, etc). However, we only need one thumbnail for each file, since the instrument archive pages do not show separate images for each file type.