Allow -seg in view_image filename #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhilbert4
changed the title
|
I'm cautiously optimistic that this is all we need. Still need to test on the dev or test server when it's free. |
bhilbert4
changed the title
|
NIRCam 1442 looks good on the test server when using this fix. And a program with non-segmented files looks ok too. @mfixstsci I think this is ready for review. |
mfixstsci
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the URL pattern for the image view pages so that segmented files can be shown. (e.g. http://jwql.stsci.edu/NIRCam/jw01442001001_04103_00001-seg004_nrca3/)
Currently these files cannot be viewed due to the hyphen in the name.
Resolves #979