Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update About page with new developers #995

Merged
merged 5 commits into from
Jul 20, 2022

Conversation

bhilbert4
Copy link
Collaborator

This PR updates the About page to show the current developers. Previously, the developers were shown in a single png that created from individual images that were stitched together. This update changes that so that separate images are used, which should make future updates much easier.

Resolves #988

@pep8speaks
Copy link

pep8speaks commented Jul 19, 2022

Hello @bhilbert4, Thank you for updating !

Line 54:34: E126 continuation line over-indented for hanging indent
Line 77:1: E402 module level import not at top of file
Line 78:1: E402 module level import not at top of file
Line 217:64: E226 missing whitespace around arithmetic operator
Line 982:13: E265 block comment should start with '# '
Line 1016:5: E265 block comment should start with '# '
Line 1078:17: W503 line break before binary operator
Line 1079:17: W503 line break before binary operator
Line 1080:17: W503 line break before binary operator
Line 1081:17: W503 line break before binary operator
Line 1405:5: E265 block comment should start with '# '
Line 1405:5: E303 too many blank lines (2)
Line 1406:5: E265 block comment should start with '# '
Line 1407:5: E265 block comment should start with '# '
Line 1408:5: E265 block comment should start with '# '
Line 1409:5: E265 block comment should start with '# '
Line 1410:5: E265 block comment should start with '# '
Line 1424:5: E303 too many blank lines (2)
Line 1475:9: E722 do not use bare 'except'

Comment last updated at 2022-07-20 19:56:31 UTC

@bhilbert4
Copy link
Collaborator Author

bhilbert4 commented Jul 19, 2022

  • Still need to figure out how to work in names beneath the images. Maybe have full names be part of the image filenames. We can extract from there. Then just need to add them below each image using caption, as is done here: https://www.w3schools.com/bootstrap/bootstrap_images.asp

Reverted to manual html for the photos. I was spending too much time trying to get it automated.

@bhilbert4 bhilbert4 added this to In progress in v1.2.0 via automation Jul 20, 2022
@bhilbert4 bhilbert4 self-assigned this Jul 20, 2022
@bhilbert4
Copy link
Collaborator Author

Looks good. @mfixstsci this is ready for review.

@bhilbert4
Copy link
Collaborator Author

Checked on the test server. Looks good.

@bhilbert4 bhilbert4 changed the title [WIP]: Update About page with new developers Update About page with new developers Jul 20, 2022
Copy link
Collaborator

@mfixstsci mfixstsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Man, I really wish I wore a different shirt that day when I got my picture taken. Thanks for the updates 😅

@mfixstsci mfixstsci merged commit b3efbac into spacetelescope:develop Jul 20, 2022
v1.2.0 automation moved this from In progress to Done Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Update the About page
3 participants