-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TSO processing in calwebb_spec2 #1473
Comments
To clarify, does this apply for both MRS and LRS data? |
This applies to all spectroscopic TSO data regardless of instrument. |
Right now the only MIRI spectroscopic mode that is treated as TSO by default is MIR_LRS-SLITLESS. Eventually the TSO option will be available on all modes, so that could then include both MIR_MRS and MIR_LRS-FIXEDSLIT (as well as MIR_IMAGE, but that's a calwebb_image2 issue). Handling IFU data, which is already in 3-D form, as TSO, which is done on a per integration basis, will be a MAJOR overhaul of the entire pipeline, because now we're talking about having to handle 4-D data structures. |
At the request of the NIRSpec team, the NIRSpec BRIGHTOBJ mode, which is a TSO mode that acquires data through the S1600A1 fixed-slit, also includes the extract_2d in calwebb_spec2 processing, just as non-TSO S1600A1 do, because the defined region of the spectral trace does not fill the entire subarray used to acquire the data. |
TSO exposures do NOT produce a rectified 2D/3D product, either in calwebb_spec2 or calwebb_tso3. The desire is to do as little harm as possible to the data. 1-D spectral extractions are done on the unrectified/unresampled 2-D data. |
I am confused. All spectroscopic data should produce 2D/3D rectified products. This is a product for the archive, not for use later in the pipeline. So, there should be no reason why TSO exposures are any different than non-TSO exposures. |
Is the NIRISS SOSS mode not a TSO by default mode? This has been my understanding. |
Check out the last entry in the table on this JDox page. This is my understanding of the modes that have TSO options. Note that there is no TSO option for MIRI IFU (MRS) observations at this point. |
Good point about the extract_2d step. Makes sense and I've updated the confluence page to reflect this. |
As of right now the modes that are treated as TSO by default (because we don't yet have a specific TSO flag from APT) are NIRCam TS image (NRC_TSIMAGE), NIRCam TS grism (NRC_TSGRISM), NIRSpec BrightObj (NRS_BRIGHTOBJ), NIRISS SOSS (NIS_SOSS), and MIRI LRS slitless (MIR_LRS-SLITLESS). |
Sounds reasonable. Any ETA on getting the TSO flag from APT through the system? |
I don't recall right now which APT or PPS release this is supposed to be in. Will need to check. We have already implemented a |
FYI: The overall issue is PR 87867 |
PR 87867 indicates, in a spreadsheet, the following for each exposure type:
So this indicates that the only modes that can be toggled are MIR_IMAGE, MIR_LRS-SLITLESS, and NIS_SOSS. Right now we treat MIR_IMAGE as non-TSO, and the remaining two as TSO by default. So logic will need to be added to all of the applicable pipeline modules, and ASN generator rules, to allow for toggling of those 3 modes. |
Which has been implemented. The current logic is to create TSO associations when either an EXP_TYPE is one of the "always TSO" or the IS_TSO flag is set. |
QuestionArchitecture question: Is this to be baked into the |
For level-2a processing we've gone the route of using a different configuration file, |
can we do |
That's a reasonable possibility. But then for consistency should we go back and rename |
Proposal on full specification:
Renaming And yes, already on coffee #2... |
ImplementationA configuration,
To Do
|
QuestionSo, do to a bunch of already-baked in constraints, the only extra steps that would be executed is background and source type using the standard config. Source type is a non-modifyier, so I'm guessing whether its executed or not is not an issue. For MIR_LRS-SLITLESS, APT does allow off-target background. So, is background alright to keep on the list? In general, backgrounds won't be available unless APT allows it. If allowed, I am presuming it should be executed. If doing background is OK, there is nothing to be done, unless I'm missing something. |
@hbushouse @sosey Any answer to the above question? |
Regardless of the answer to the question about background, the pathloss steps also needs consideration. NIRSpec BrightObj, which is a TSO mode, is obtained using the S1600 fixed-slit. NIRSpec fixed-slit data normally have the pathloss step applied, so in the case of BrightObj it would need to be skipped. So given that we will need a custom cfg to at least skip the pathloss step, then we might as well include skipping the background too. |
Oh, and pathloss correction is also about to be implemented for NIRISS SOSS mode too, but given that SOSS mode is TSO by default, application of pathloss is in conflict with the JCCWG table specifying which steps to apply/skip for TSO. Clearly we need further discussion with the JCCWG and TSO WG. |
To summarize:
We need to skip Because we need to skip 1 or more steps in both |
@hbushouse so no need to implement |
Correct, no |
Unblocking and going with the separate config files, as specified above. |
Looks good! |
The TSO observations need to have slightly different processing in calwebb_spec2 than the rest of the observations.
Specifically the only steps that are done are WCS info, flat field correction, flux calibration, and rectified 2D/3D product.
The text was updated successfully, but these errors were encountered: