Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For NIRSpec flat field, assign 1 if wavelength is out of bounds #2677

Closed
philhodge opened this issue Oct 8, 2018 · 1 comment
Closed

For NIRSpec flat field, assign 1 if wavelength is out of bounds #2677

philhodge opened this issue Oct 8, 2018 · 1 comment
Assignees
Milestone

Comments

@philhodge
Copy link
Contributor

From James Muzerolle:
"Whenever a pixel wavelength is outside the range of the corresponding reference file, the pipeline should set the flat correction factor to 1 (no extrapolations). It probably would be a good idea to set a DQ flag in that case. The NO_FLAT_FIELD flag will not track cases where some but not all of the 6 components (d/f/s-flat, 2D and fast vector) are missing. Perhaps there should be a "PARTIAL_FLAT_FIELD" flag? I don't know how common this might be; probably not frequent, maybe most often an issue for the S-flat at edges of some MOS subwindows."

@philhodge philhodge added this to the 0.13.0 milestone Oct 8, 2018
@philhodge philhodge self-assigned this Oct 8, 2018
philhodge added a commit to philhodge/jwst that referenced this issue Oct 25, 2018
There are several components for the NIRSpec flat field.  For each section
of the instrument (the fore-optics, the spectrograph, and the detector),
there can be both a fast variation (with wavelength) and a slow variation
component.  For a given pixel of the science data, it may be that the
wavelength of the science data is undefined, or the wavelength might be
out of range for one or more components of the flat field, or the pixel
can be flagged as bad in the reference file for a component.  In any such
case, the flat field to be applied to the data will be set to 1, and the
associated data quality array will be non-zero, such as UNDEFINED_FLAT or
NO_FLAT_FIELD.  See issue spacetelescope#2677.
@philhodge
Copy link
Contributor Author

Closed with PR #2775.

nden pushed a commit that referenced this issue Oct 30, 2018
There are several components for the NIRSpec flat field.  For each section
of the instrument (the fore-optics, the spectrograph, and the detector),
there can be both a fast variation (with wavelength) and a slow variation
component.  For a given pixel of the science data, it may be that the
wavelength of the science data is undefined, or the wavelength might be
out of range for one or more components of the flat field, or the pixel
can be flagged as bad in the reference file for a component.  In any such
case, the flat field to be applied to the data will be set to 1, and the
associated data quality array will be non-zero, such as UNDEFINED_FLAT or
NO_FLAT_FIELD.  See issue #2677.
nden pushed a commit that referenced this issue Oct 30, 2018
There are several components for the NIRSpec flat field.  For each section
of the instrument (the fore-optics, the spectrograph, and the detector),
there can be both a fast variation (with wavelength) and a slow variation
component.  For a given pixel of the science data, it may be that the
wavelength of the science data is undefined, or the wavelength might be
out of range for one or more components of the flat field, or the pixel
can be flagged as bad in the reference file for a component.  In any such
case, the flat field to be applied to the data will be set to 1, and the
associated data quality array will be non-zero, such as UNDEFINED_FLAT or
NO_FLAT_FIELD.  See issue #2677.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant