Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation updates for WFSS and TSGRISM mode #2538

Merged
merged 3 commits into from
Oct 2, 2018

Conversation

sosey
Copy link
Member

@sosey sosey commented Sep 21, 2018

This adds documentation for the updates in #1710 and #1756

@sosey sosey added this to the 0.12.0 milestone Sep 21, 2018
@sosey sosey self-assigned this Sep 21, 2018
@sosey
Copy link
Member Author

sosey commented Sep 24, 2018

@stscieisenhamer I updated the docs to remove the reference for the segementation image in the association file for WFSS but the associated graphic should also be updated

@stscieisenhamer
Copy link
Collaborator

Is this the change you were expecting?
workflow-wfss.pdf

@sosey
Copy link
Member Author

sosey commented Sep 27, 2018

sorry....got lost in my emails! Looks good :)

@stscieisenhamer
Copy link
Collaborator

OK. How about if you merge this and I'll make another PR for the graphics? Or I can PR your PR?

@sosey
Copy link
Member Author

sosey commented Sep 27, 2018

sure, go ahead and PR this, then it all goes in together? :)

@stscieisenhamer
Copy link
Collaborator

well, not a pr on a pr, but the commit with the updated graphics is now there.

@sosey
Copy link
Member Author

sosey commented Oct 2, 2018

closes #2534

@sosey sosey merged commit e81cf19 into spacetelescope:master Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants