jp-1690 calspec3 cube_build clean up #5347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5347 +/- ##
==========================================
+ Coverage 52.67% 52.78% +0.10%
==========================================
Files 407 409 +2
Lines 36907 37027 +120
Branches 5725 5745 +20
==========================================
+ Hits 19442 19545 +103
- Misses 16227 16239 +12
- Partials 1238 1243 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
hbushouse
reviewed
Sep 18, 2020
jwst/cube_build/blot_cube_build.py
Outdated
| # ********************************************************************** | ||
|
|
||
| def blot_info(self): | ||
| """ Prints the basic paramters of the blot image and median sky cube | ||
| """ | ||
| log.info('Information on Blotting') | ||
| log.info('Working with instrument %s %s', self.instrument, | ||
| self.detector) | ||
| log.info('Working with instrument %s ', self.instrument) |
There was a problem hiding this comment.
Minor nit, but could remove unused white space after %s
jwst/cube_build/ifu_cube.py
Outdated
| # If all the data is flagged as DO_NOT_USE - not common then log warning and skip data | ||
| nn = wave.size | ||
| no_data = False | ||
| if nn == 0: |
There was a problem hiding this comment.
Is nn used anywhere else? If not, why not just consolidate these lines into:
if wave.size == 0:
no_data = True
else:
no_data = False
hbushouse
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up of making single cubes and blotted cubes.