Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in assign_wcs.util.bounding_box_from_subarray function #5543

Merged
merged 2 commits into from Dec 16, 2020

Conversation

jdavies-st
Copy link
Collaborator

Subarray bounding boxes are now the correct size. Before they were 1 pixel too small.

Resolves #5542 / JP-1818

@jdavies-st jdavies-st added this to the Build 7.7 milestone Dec 16, 2020
@jdavies-st jdavies-st requested a review from nden December 16, 2020 19:03
@codecov
Copy link

codecov bot commented Dec 16, 2020

Codecov Report

Merging #5543 (b30d74b) into master (c129fee) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5543      +/-   ##
==========================================
+ Coverage   71.25%   71.26%   +0.01%     
==========================================
  Files         410      410              
  Lines       36426    36462      +36     
  Branches     5677     5683       +6     
==========================================
+ Hits        25954    25985      +31     
- Misses       8826     8831       +5     
  Partials     1646     1646              
Flag Coverage Δ *Carryforward flag
nightly 71.24% <0.00%> (ø) Carriedforward from 8b06fea
unit 51.82% <100.00%> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/assign_wcs/util.py 72.42% <100.00%> (+1.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c129fee...b30d74b. Read the comment docs.

@nden nden merged commit b592569 into spacetelescope:master Dec 16, 2020
@jdavies-st jdavies-st deleted the JP-1818-subarray-bounding-box branch December 17, 2020 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

subarray bounding boxes are 1 pixel too small
3 participants