JP-2693: Flag groups do_not_use after detected ramp jumps #6943
Conversation
|
I just changed ticket number '2963' -> '2693' in description. |
karllark
force-pushed
the
jump_transient_flag
branch
from
4476592
to
7d71a24
Compare
|
If understand things correctly, the tests are failing as the version of stcal used for the tests does not include the changes needed for this PR. After the stcal PR has been merged, then maybe the tests will pass. The tests pass on my computer when the appropriate branch on stscal (jump_transient_flag) is used. |
karllark
force-pushed
the
jump_transient_flag
branch
from
8460ce2
to
5e2b61e
Compare
|
Ready for review. Likely, the corresponding PR in stcal should be reviewed at the same time. |
|
@cshanahan1 are you good with this now that all review comments have been addressed? |
|
@karllark I think this PR branch may need to be rebased from master. Looks like conflicts are preventing the CI tests from running. |
karllark
force-pushed
the
jump_transient_flag
branch
from
0fb895c
to
625d634
Compare
Done. |
|
I think the remaining CI failures, which are confined to ramp_fitting unit tests, are due to other PR's included in the stcal 1.1.0 release, and maybe fixed by #6949 once it gets merged. Retesting that PR right now. |
Codecov Report
@@ Coverage Diff @@
## master #6943 +/- ##
==========================================
+ Coverage 79.24% 79.26% +0.01%
==========================================
Files 414 414
Lines 37478 37508 +30
==========================================
+ Hits 29701 29731 +30
Misses 7777 7777
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
OK, #6949 has now been merged to update the truth values in the unit tests that were causing CI failures. So one more rebase to kickoff the tests again. |
karllark
force-pushed
the
jump_transient_flag
branch
from
625d634
to
abf8ce9
Compare
…cope#6943) * passing after_jump parameters through to stcal * adding after_jump test * adding to change log * adding after ramp flagging docs * fixing docs * Responding to PR comments (cherry picked from commit 2ae48e3)
Resolves JP-2693
This PR implements the enhancement to the jump step where groups after detected jumps are flagged do_not_use. This "corrects" transients that have been seen to make the slope after a jump different than before. This PR allows for flagging to be different for two different jump thresholds.
The main changes are in spacetelescope/stcal#110 and this PR provides the needed interface for
jwst.Checklist
CHANGES.rstwithin the relevant release section