Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JP-3431 Ensure that default WCS information is set for Guiding modes that fail pointing determination #7983

Merged
merged 4 commits into from
Sep 28, 2023
Merged

JP-3431 Ensure that default WCS information is set for Guiding modes that fail pointing determination #7983

merged 4 commits into from
Sep 28, 2023

Conversation

stscieisenhamer
Copy link
Collaborator

@stscieisenhamer stscieisenhamer commented Sep 28, 2023 •
edited by hbushouse

Resolves JP-3431

Closes #7981

This PR addresses the issue that if WCS information for guiding modes cannot be determined from engineering, that no default information is saved to the exposure. The basic information that is found from engineering are the CRPIX values. If they cannot be determined, CRPIX are set to 0.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@stscieisenhamer stscieisenhamer added bug sdp Bugs arising due to SDP testing set_telescope_pointing labels Sep 28, 2023
@stscieisenhamer stscieisenhamer added this to the Build 10.0 milestone Sep 28, 2023
@stscieisenhamer stscieisenhamer requested a review from a team as a code owner September 28, 2023 15:34
@stscieisenhamer stscieisenhamer self-assigned this Sep 28, 2023
@stscieisenhamer
Copy link
Collaborator Author

Regression Test Try 1

@codecov
Copy link

codecov bot commented Sep 28, 2023 •
edited

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Files Coverage Δ
jwst/lib/set_telescope_pointing.py 74.17% <0.00%> (-0.35%) ⬇️

📢 Thoughts on this report? Let us know!.

nden
nden reviewed Sep 28, 2023
View reviewed changes
CHANGES.rst Outdated Show resolved Hide resolved
nden
nden approved these changes Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@nden nden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

hbushouse
hbushouse approved these changes Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hbushouse @nden
Update CHANGES.rst
77c876a 
Co-authored-by: Nadia Dencheva <nadia.astropy@gmail.com>
@hbushouse hbushouse merged commit 644f2e3 into spacetelescope:master Sep 28, 2023
21 of 22 checks passed
@stscijgbot-jp stscijgbot-jp mentioned this pull request Sep 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nden nden nden approved these changes

@hbushouse hbushouse hbushouse approved these changes

Assignees

@stscieisenhamer stscieisenhamer

Labels
bug sdp Bugs arising due to SDP testing set_telescope_pointing testing
Projects
None yet
Milestone
Build 10.0
Development

Successfully merging this pull request may close these issues.

Ensure default WCS is set for guiding products
3 participants
@stscieisenhamer @nden @hbushouse