Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JP-3430: Updates for FilterOffset docs #7991

Merged
merged 2 commits into from
Oct 3, 2023
Merged

JP-3430: Updates for FilterOffset docs #7991

merged 2 commits into from
Oct 3, 2023

Conversation

hbushouse
Copy link
Collaborator

@hbushouse hbushouse commented Oct 3, 2023 •
edited

Resolves JP-3430

Closes #7975

This PR makes updates to the FilterOffset ref file docs, as requested in JP-3430.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@hbushouse hbushouse added this to the Build 10.0 milestone Oct 3, 2023
@hbushouse hbushouse requested a review from a team as a code owner October 3, 2023 16:50
tapastro
tapastro approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@tapastro tapastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hbushouse hbushouse merged commit f4a20f8 into spacetelescope:master Oct 3, 2023
19 checks passed
@hbushouse hbushouse deleted the jp3430 branch October 3, 2023 17:35
@stscijgbot-jp stscijgbot-jp mentioned this pull request Oct 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tapastro tapastro tapastro approved these changes

@penaguerrero penaguerrero Awaiting requested review from penaguerrero

Assignees
No one assigned
Labels
documentation reference files
Projects
None yet
Milestone
Build 10.0
Development

Successfully merging this pull request may close these issues.

NIRISS filteroffset reference file not listed
2 participants
@hbushouse @tapastro