Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a few Numpy 2.0 deprecation warnings #7999

Merged
merged 6 commits into from
Oct 10, 2023
Merged

Fix a few Numpy 2.0 deprecation warnings #7999

merged 6 commits into from
Oct 10, 2023

Conversation

nden
Copy link
Collaborator

@nden nden commented Oct 6, 2023 •
edited by hbushouse

Resolves JP-nnnn

Closes #

This PR addresses deprecations warnings seen in the regression tests:

  • Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future.
  • association.py:215: UserWarning: 'expname' contains path, but should only be a filename.
  • DeprecationWarning: alltrueis deprecated as of NumPy 1.25.0, and will be removed in NumPy 2.0.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

regression test run: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/988/

@nden nden requested a review from a team as a code owner October 6, 2023 20:38
@nden nden marked this pull request as draft October 6, 2023 20:41
@codecov
Copy link

codecov bot commented Oct 6, 2023 •
edited

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
jwst/cube_build/ifu_cube.py 88.60% <100.00%> (ø)
jwst/photom/photom.py 88.20% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

@nden nden marked this pull request as ready for review October 7, 2023 12:22
@nden nden requested a review from jemorrison October 7, 2023 12:22
@nden nden added this to the Build 10.1 milestone Oct 7, 2023
hbushouse
hbushouse approved these changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nden nden merged commit 3aecec7 into spacetelescope:master Oct 10, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbushouse hbushouse hbushouse approved these changes

@jemorrison jemorrison Awaiting requested review from jemorrison

Assignees
No one assigned
Labels
cube_build photom testing wfs_combine
Projects
None yet
Milestone
Build 10.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nden @hbushouse