JP-3440: Revert change clobbering extra pixels near bad reference pixels #8005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melanieclarke
force-pushed
the
patch_refpix_clobber
branch
from
ef0bafe
to
71d173c
Compare
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
melanieclarke
changed the title
|
Regression test run started at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1001 |
|
Regression tests show changes downstream of the refpix step for two NRS datasets, which I'm assuming are expected. |
|
I think those are expected changes. Running locally, I can see the bad rows in the truth files. |
hbushouse
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JP-3440
Closes #8008
This PR reverts a change associated with JP-3321, PR 7745, setting two additional detector columns next to bad reference pixels to zero. Depending on the bad reference pixel location, the additional columns set to zero might have been adjacent interleaved reference pixels, or might have been science data. If science data, the effect is clear in the rate files: the affected data appear as bad rows with near-zero values.
Checklist for maintainers
CHANGES.rstwithin the relevant release sectionHow to run regression tests on a PR