Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use --props instead of --build in okify_regtests #8031

Merged
merged 4 commits into from
Nov 1, 2023
Merged

use --props instead of --build in okify_regtests #8031

merged 4 commits into from
Nov 1, 2023

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Oct 26, 2023 •
edited

This PR attempts to address an issue in okify_regtests where using --build in the Jfrog query appears to crash the server process with a 500 error.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@zacharyburnett zacharyburnett self-assigned this Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
jwst/scripts/okify_regtests.py 23.63% <ø> (ø)

📢 Thoughts on this report? Let us know!.

@zacharyburnett zacharyburnett changed the title use --props instead of --builds in Jfrog query use --props instead of --build in okify_regtests Oct 30, 2023
@zacharyburnett @braingram
remove single quotes
e39addf 
Co-authored-by: Brett Graham <brettgraham@gmail.com>
hbushouse
hbushouse approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the syntax that worked for me.

@zacharyburnett zacharyburnett marked this pull request as ready for review November 1, 2023 15:11
@zacharyburnett zacharyburnett requested a review from a team as a code owner November 1, 2023 15:11
@zacharyburnett zacharyburnett merged commit 61e2910 into spacetelescope:master Nov 1, 2023
23 of 24 checks passed
@zacharyburnett zacharyburnett deleted the scripts/okify_query branch November 1, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braingram braingram braingram left review comments

@hbushouse hbushouse hbushouse approved these changes

Assignees

@zacharyburnett zacharyburnett

Labels
no-changelog-entry-needed regression_testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zacharyburnett @braingram @hbushouse