JP-3451: Include zero-valued pixels in difference calculation

[tapastro]

Resolves JP-3451

Closes #8037

This PR addresses regression test errors for NIRISS SOSS after a recent delivery of updated reference files. This fix allows the difference calculation inside the bad dispersion direction method to see zero-valued pixels, which will allow it to overwrite them before throwing an error.

Checklist for maintainers

• added entry in CHANGES.rst within the relevant release section
• updated or added relevant tests
• updated relevant documentation
• added relevant milestone
• added relevant label(s)
• ran regression tests, post a link to the Jenkins job below.
  How to run regression tests on a PR
• Make sure the JIRA ticket is resolved properly

[tapastro]

Starting a regression test run: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1027/

[codecov]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files	Coverage Δ
jwst/extract_1d/soss_extract/atoca_utils.py	69.52% <0.00%> (-0.13%)	⬇️

📢 Thoughts on this report? Let us know!.

[hbushouse]

No idea if this is a correct solution or not, but it seems to work. Needs a change log entry.

[tapastro]

Changelog update added; regression test shows failure with ~16% of pixels showing a difference. In reality it's 100% of science pixels, and it's expected because the updates here (with 1144) include an update to the photom ref file for SOSS that corrects a MJy -> Jy unit error, leading to ~1.e6 differences.

[hbushouse]

No idea if this is a correct solution or not, but it seems to work. Needs a change log entry.

[hbushouse]

@tapastro Is it OK to go ahead and merge this now, or are you waiting for updated reference files or anything like that?

[tapastro]

I believe this should work for the old (current) ref files, and was tested above to work with the context that was skipped, such that the team can re-deliver the updates. I can run the regtests again on the current newest context, which does not contain the updates.

[tapastro]

Re-run of regtests shows no failures: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1049/