Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop python 3.12 support #8042

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Oct 31, 2023

jwst cannot yet support python 3.12 due to an upper pin on scipy:

jwst/setup.cfg

Line 44 in 7f1c5ca

scipy>=1.6.0,<1.10.0

This is proving problematic to remove in part due to different output from scipy.signal.medfilt (see: #8033).

This PR removes python 3.12 support and the consistently failing python 3.12 CI job (which fails to install and produces no additional useful output) to make reviewing other changes easier.

A follow-up PR (possibly #8033) will add python 3.12 support. If this PR is approved and merged a tracking issue will be opened for adding python 3.12 support.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@github-actions github-actions bot added testing installation automation Continuous Integration (CI) and testing automation tools labels Oct 31, 2023
@braingram braingram marked this pull request as ready for review October 31, 2023 20:17
@braingram braingram requested a review from a team as a code owner October 31, 2023 20:17
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@hbushouse hbushouse merged commit c08ab08 into spacetelescope:master Nov 1, 2023
22 of 23 checks passed
@braingram braingram deleted the drop_py312 branch November 1, 2023 13:00
hbushouse added a commit that referenced this pull request Dec 5, 2023
…rt. (#8093)

Co-authored-by: Howard Bushouse <bushouse@stsci.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation Continuous Integration (CI) and testing automation tools installation testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants