Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3426: Check WFSS background mask against input dq array #8070

Merged
merged 4 commits into from
Nov 15, 2023

Conversation

tapastro
Copy link
Contributor

@tapastro tapastro commented Nov 10, 2023

Resolves JP-3426

This PR addresses errors seen in operations processing of a WFSS program - the background subtraction step generates a mask by excluding pixels deemed to have source flux using bounding boxes. In the case of the problematic dataset, the only pixels remaining after source exclusion is the 4-pixel wide boundary corresponding to reference pixels. This PR adds an additional check by masking the input model DQ array and ensuring the remaining pixels do not have DO_NOT_USE flagged.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@tapastro tapastro added this to the Build 10.1 milestone Nov 10, 2023
@tapastro tapastro requested a review from a team as a code owner November 10, 2023 15:23
@tapastro
Copy link
Contributor Author

tapastro commented Nov 10, 2023

Made an edit to addressing dqflags values rather than assuming flag of interest is 1, restarting the regtest run.

Regtests here: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1051/

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9dfaa37) 75.95% compared to head (0480752) 75.95%.

Files Patch % Lines
jwst/background/background_sub.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8070      +/-   ##
==========================================
- Coverage   75.95%   75.95%   -0.01%     
==========================================
  Files         459      459              
  Lines       37591    37592       +1     
==========================================
  Hits        28552    28552              
- Misses       9039     9040       +1     
Flag Coverage Δ *Carryforward flag
nightly 77.37% <ø> (-0.01%) ⬇️ Carriedforward from 9dfaa37

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hbushouse
Copy link
Collaborator

No regtest failures and CI's look good. I'm merging.

@hbushouse hbushouse merged commit e800077 into spacetelescope:master Nov 15, 2023
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants