-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3426: Check WFSS background mask against input dq array #8070
JP-3426: Check WFSS background mask against input dq array #8070
Conversation
Made an edit to addressing dqflags values rather than assuming flag of interest is 1, restarting the regtest run. Regtests here: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1051/ |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #8070 +/- ##
==========================================
- Coverage 75.95% 75.95% -0.01%
==========================================
Files 459 459
Lines 37591 37592 +1
==========================================
Hits 28552 28552
- Misses 9039 9040 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
No regtest failures and CI's look good. I'm merging. |
Resolves JP-3426
This PR addresses errors seen in operations processing of a WFSS program - the background subtraction step generates a mask by excluding pixels deemed to have source flux using bounding boxes. In the case of the problematic dataset, the only pixels remaining after source exclusion is the 4-pixel wide boundary corresponding to reference pixels. This PR adds an additional check by masking the input model DQ array and ensuring the remaining pixels do not have DO_NOT_USE flagged.
Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR