Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3469: Replace nanmedian with masked array median in ifu_autocen #8080

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

drlaw1558
Copy link
Collaborator

@drlaw1558 drlaw1558 commented Nov 20, 2023

Resolves JP-3469 by replacing a nanmedian calculation with a numpy masked median calculation.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@drlaw1558 drlaw1558 requested a review from a team as a code owner November 20, 2023 16:14
@hbushouse hbushouse changed the title Replace nanmedian with masked array median in ifu_autocen JP-3469: Replace nanmedian with masked array median in ifu_autocen Nov 20, 2023
@hbushouse hbushouse added this to the Build 10.1 milestone Nov 20, 2023
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5b63bda) 75.95% compared to head (a4759ef) 75.95%.
Report is 1 commits behind head on master.

❗ Current head a4759ef differs from pull request most recent head e6292a6. Consider uploading reports for the commit e6292a6 to get more accurate results

Files Patch % Lines
jwst/extract_1d/ifu.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8080   +/-   ##
=======================================
  Coverage   75.95%   75.95%           
=======================================
  Files         459      459           
  Lines       37597    37597           
=======================================
  Hits        28557    28557           
  Misses       9040     9040           
Flag Coverage Δ *Carryforward flag
nightly 77.37% <ø> (ø) Carriedforward from 5b63bda

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hbushouse
Copy link
Collaborator

Started a regtest run at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST/2661

@hbushouse
Copy link
Collaborator

Regtest run was clean (unrelated failures)

@hbushouse hbushouse merged commit 4c717d0 into spacetelescope:master Nov 21, 2023
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants