Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3473: Include non_science pixels in count of excluded pixels #8090

Merged

Conversation

tapastro
Copy link
Contributor

@tapastro tapastro commented Nov 27, 2023

Resolves JP-3473

Closes #8087

This PR addresses a bug found in the pixel replacement code. When a spatial profile contains pixels all flagged either DO_NOT_USE or NON_SCIENCE, the profile is incorrectly added to the list to be worked on, despite no pixels being considered a science pixel. NON_SCIENCE pixels are now included in the count of pixels to exclude from consideration.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@tapastro tapastro added this to the Build 10.1 milestone Nov 27, 2023
@tapastro tapastro requested a review from a team as a code owner November 27, 2023 16:06
@tapastro
Copy link
Contributor Author

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (e674c9d) 75.92% compared to head (116f52a) 75.92%.

Files Patch % Lines
jwst/pixel_replace/pixel_replace.py 0.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8090      +/-   ##
==========================================
- Coverage   75.92%   75.92%   -0.01%     
==========================================
  Files         459      459              
  Lines       37615    37619       +4     
==========================================
  Hits        28561    28561              
- Misses       9054     9058       +4     
Flag Coverage Δ *Carryforward flag
nightly 77.37% <ø> (ø) Carriedforward from e674c9d

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 2 regtest failures are unrelated. Looks good.

@hbushouse hbushouse merged commit 0f6a93b into spacetelescope:master Nov 30, 2023
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pixel_replace fails to capture empty rows
2 participants