Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3223: Extract_2d 'slit_name' parameter fails for NRS_MSASPEC slits #8108

Merged
merged 3 commits into from
Dec 5, 2023

Conversation

penaguerrero
Copy link
Contributor

@penaguerrero penaguerrero commented Dec 5, 2023

Resolves JP-3223

Closes #

This PR addresses potential break in a future datamodel, where the slit name for an MSA slitlet is not an integer.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (00110b3) 75.94% compared to head (563dd7f) 75.95%.

❗ Current head 563dd7f differs from pull request most recent head 1caf2d0. Consider uploading reports for the commit 1caf2d0 to get more accurate results

Files Patch % Lines
jwst/extract_2d/nirspec.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8108   +/-   ##
=======================================
  Coverage   75.94%   75.95%           
=======================================
  Files         460      460           
  Lines       37629    37626    -3     
=======================================
  Hits        28577    28577           
+ Misses       9052     9049    -3     
Flag Coverage Δ *Carryforward flag
nightly 77.37% <ø> (ø) Carriedforward from f13f8f5

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hbushouse hbushouse added this to the Build 10.1 milestone Dec 5, 2023
@hbushouse
Copy link
Collaborator

Please run regtests in JWST-Developers-Pull-Requests

@penaguerrero
Copy link
Contributor Author

regtests ran, results at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1080/

failures appear unrelated to this PR's changes

@hbushouse
Copy link
Collaborator

regtests ran, results at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1080/

failures appear unrelated to this PR's changes

Agreed. Appears to be due to new NIRSpec flat-field ref files just delivered to Ops.

@hbushouse hbushouse merged commit f77b5d6 into spacetelescope:master Dec 5, 2023
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants