Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update labeler.yml for labeler v5 #8117

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

braingram
Copy link
Collaborator

labeler v5 introduced breaking changes for the config file format.

This PR updates the config to the new format.

As the workflow that uses this action runs on pull_request_target the CI run for this PR will not reflect the config file changes in this PR (the config file will be pulled from the main branch). To test this PR I opened a test PR against the source branch for this PR with some changes that should trigger labels.
braingram#1
The labeler action on the test PR ran without errors and labels were applied:
https://github.com/braingram/jwst/actions/runs/7159251698/job/19492299084?pr=1

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

Copy link

codecov bot commented Dec 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b8e85bd) 75.32% compared to head (5466e12) 75.32%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8117   +/-   ##
=======================================
  Coverage   75.32%   75.32%           
=======================================
  Files         464      464           
  Lines       38002    38002           
=======================================
  Hits        28626    28626           
  Misses       9376     9376           
Flag Coverage Δ *Carryforward flag
nightly 77.37% <ø> (ø) Carriedforward from b8e85bd

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zacharyburnett zacharyburnett merged commit a1e4630 into spacetelescope:master Dec 11, 2023
28 of 30 checks passed
@braingram braingram deleted the labeler_config branch December 11, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants