Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3248 MIRI Subarrays 390 Hz EMI bug fix 3 #8151

Merged
merged 4 commits into from
Dec 20, 2023

Conversation

penaguerrero
Copy link
Contributor

@penaguerrero penaguerrero commented Dec 19, 2023

Resolves JP-3248

Closes #

This PR addresses fixing bug with subarray=full readpattern=slow

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@penaguerrero penaguerrero requested a review from a team as a code owner December 19, 2023 18:17
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (31e3a22) 75.24% compared to head (c5a6305) 75.23%.
Report is 1 commits behind head on master.

Files Patch % Lines
jwst/emicorr/emicorr.py 60.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8151      +/-   ##
==========================================
- Coverage   75.24%   75.23%   -0.01%     
==========================================
  Files         470      470              
  Lines       38428    38432       +4     
==========================================
+ Hits        28915    28916       +1     
- Misses       9513     9516       +3     
Flag Coverage Δ *Carryforward flag
nightly 77.37% <ø> (ø) Carriedforward from 31e3a22

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hbushouse hbushouse changed the title JP-3248 MIRI Subarrays 390 Hz EMI JP-3248 MIRI Subarrays 390 Hz EMI bug fix 3 Dec 20, 2023
@hbushouse hbushouse added this to the Build 10.1 milestone Dec 20, 2023
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR branch has passed Misty's entire battery of MIRI test notebooks, so it looks good.

@hbushouse hbushouse merged commit c357f75 into spacetelescope:master Dec 20, 2023
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants