-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sregion at the end of TweakRegStep #8158
Update sregion at the end of TweakRegStep #8158
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8158 +/- ##
=======================================
Coverage 75.24% 75.25%
=======================================
Files 470 470
Lines 38430 38427 -3
=======================================
- Hits 28918 28917 -1
+ Misses 9512 9510 -2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Regression tests run here: |
I believe |
@nden Thank you for the information. The reason I want to update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks! |
bb68f7c
to
e34aad4
Compare
The output eventually does get written out and archived as the _crf.fits files via |
This PR fixes an issue where sregion is not updated after corrections are applied to the WCS.
Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR