Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to exclude Python 3.12 from supported versions. #8161

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

nden
Copy link
Collaborator

@nden nden commented Jan 2, 2024

This PR adds caveats back into the README, warning users that they need to create an environment using python < 3.12

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

Copy link
Contributor

@tapastro tapastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4fb9f14) 75.25% compared to head (db96e00) 75.25%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8161   +/-   ##
=======================================
  Coverage   75.25%   75.25%           
=======================================
  Files         470      470           
  Lines       38426    38426           
=======================================
  Hits        28916    28916           
  Misses       9510     9510           
Flag Coverage Δ *Carryforward flag
nightly 77.37% <ø> (ø) Carriedforward from 4fb9f14

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hbushouse hbushouse added this to the Build 10.1 milestone Jan 3, 2024
@hbushouse hbushouse merged commit 5bae5a0 into spacetelescope:master Jan 3, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants