Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3505: Update ASN rules for NRS MOS compromise dither patterns #8184

Merged
merged 5 commits into from
Jan 12, 2024

Conversation

hbushouse
Copy link
Collaborator

@hbushouse hbushouse commented Jan 10, 2024

Resolves JP-3505

Closes #8183

This PR updates the level-2 ASN rules to accommodate NIRSpec MOS dither patterns that include sub-pixel dithering, so that only exposures from other nod positions get designated as "background" members in spec2 ASN files. This mechanism was already in place for NIRSpec fixed-slit (FS) observations that use both primary nods and sub-pixel dithers, so it just needed to be extended to also include MSA observations.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@hbushouse hbushouse added this to the Build 10.2 milestone Jan 10, 2024
@hbushouse hbushouse requested a review from a team as a code owner January 10, 2024 20:46
@hbushouse hbushouse marked this pull request as draft January 10, 2024 20:48
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (19925fc) 77.37% compared to head (f1780b0) 75.26%.

Files Patch % Lines
jwst/associations/lib/rules_level2_base.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8184      +/-   ##
==========================================
- Coverage   77.37%   75.26%   -2.11%     
==========================================
  Files         451      470      +19     
  Lines       35289    38430    +3141     
==========================================
+ Hits        27304    28924    +1620     
- Misses       7985     9506    +1521     
Flag Coverage Δ *Carryforward flag
nightly 77.37% <ø> (-0.01%) ⬇️ Carriedforward from c1829ec

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hbushouse
Copy link
Collaborator Author

@hbushouse
Copy link
Collaborator Author

1 regression test failure was due to an unrelated unclosed file error. Succeeds when run locally on my PR branch.

@hbushouse
Copy link
Collaborator Author

The unit test that I added uses an example pool file taken directly from one observation in program 2640, consisting of an exposure sequence with 3 primary nods, 3 subpixel dithers at each nod, and using both NRS detectors. So a total of 18 DMS exposures, where each "spec2" asn file that gets created has one of the 18 exposures treated as "science", and the 6 exposures from other nod positions (2 nods x 3 subpix dithers) as "background" members.

@hbushouse hbushouse marked this pull request as ready for review January 11, 2024 14:32
@hbushouse hbushouse merged commit dadeb51 into spacetelescope:master Jan 12, 2024
27 of 29 checks passed
@hbushouse hbushouse deleted the jp-3505 branch January 12, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ASN rules to handle NIRSpec MOS exposures with sub-pixel dithers
2 participants