Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3509: Cut cube collapse for autocentroiding short of 26 microns #8199

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

drlaw1558
Copy link
Collaborator

@drlaw1558 drlaw1558 commented Jan 16, 2024

Resolves JP-3509

Closes #8193

This PR addresses JP-3509 by ensuring that only cube wavelengths shortward of 26 microns are used for the IFU autocentroiding.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (f23d4d9) 75.24% compared to head (853e74e) 75.24%.
Report is 4 commits behind head on master.

Files Patch % Lines
jwst/extract_1d/ifu.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8199      +/-   ##
==========================================
- Coverage   75.24%   75.24%   -0.01%     
==========================================
  Files         470      470              
  Lines       38431    38433       +2     
==========================================
  Hits        28919    28919              
- Misses       9512     9514       +2     
Flag Coverage Δ *Carryforward flag
nightly 77.37% <ø> (ø) Carriedforward from f23d4d9

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hbushouse hbushouse added this to the Build 10.2 milestone Jan 22, 2024
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@hbushouse
Copy link
Collaborator

@hbushouse
Copy link
Collaborator

Regtest run 1165 got hung overnight. Starting a new one at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1167

@hbushouse
Copy link
Collaborator

Latest regtest failures are all benign and unrelated.

@hbushouse hbushouse merged commit c176ff3 into spacetelescope:master Jan 23, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IFU source autocentroiding can fail in Ch4C
2 participants