Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RTD installation instructions #8200

Merged
merged 6 commits into from
Jan 17, 2024

Conversation

hbushouse
Copy link
Collaborator

@hbushouse hbushouse commented Jan 17, 2024

This PR addresses an issue raised in Help Desk ticket INC0196726 where there was no mention of the fact that we are currently limited to installing jwst with python<=3.11. So I've updated all the places where "conda create" is mentioned.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f479fcc) 75.24% compared to head (3523670) 75.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8200   +/-   ##
=======================================
  Coverage   75.24%   75.24%           
=======================================
  Files         470      470           
  Lines       38431    38431           
=======================================
  Hits        28919    28919           
  Misses       9512     9512           
Flag Coverage Δ *Carryforward flag
nightly 77.37% <ø> (ø) Carriedforward from 4cfb4ed

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hbushouse hbushouse merged commit 649b28f into spacetelescope:master Jan 17, 2024
29 checks passed
@hbushouse hbushouse deleted the fix_install_info branch January 17, 2024 20:07
@jdavies-st
Copy link
Collaborator

I note that you are successfully testing under 3.12 now in the 1.13.x tagged versions and on master. Will Python 3.12 eventually be officially supported once one of those 1.13.x releases makes it to pypi?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants