Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3515: Spec2Pipeline turns off NSClean for BOTS #8256

Merged
merged 4 commits into from
Feb 7, 2024

Conversation

penaguerrero
Copy link
Contributor

@penaguerrero penaguerrero commented Feb 1, 2024

Resolves JP-3515

Closes #8208

This PR addresses adding BOTS data to spec2 modes when skip is False.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (557c3fa) 75.18% compared to head (7cfd91b) 75.18%.
Report is 1 commits behind head on master.

Files Patch % Lines
jwst/pipeline/calwebb_spec2.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8256   +/-   ##
=======================================
  Coverage   75.18%   75.18%           
=======================================
  Files         470      470           
  Lines       38549    38549           
=======================================
  Hits        28983    28983           
  Misses       9566     9566           
Flag Coverage Δ *Carryforward flag
nightly 77.37% <ø> (ø) Carriedforward from 557c3fa

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@penaguerrero
Copy link
Contributor Author

@hbushouse hbushouse added this to the Build 10.2 milestone Feb 5, 2024
@hbushouse hbushouse added NIRSPEC nsclean NIRSpec NSClean algorithm labels Feb 5, 2024
CHANGES.rst Outdated Show resolved Hide resolved
@hbushouse
Copy link
Collaborator

Check the documentation for both calwebb_spec2 and nsclean to see if it needs updating to explicitly mention that we cover the BOTS mode.

@hbushouse
Copy link
Collaborator

Regtest results are clean.

Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hbushouse hbushouse merged commit 73830ac into spacetelescope:master Feb 7, 2024
28 of 29 checks passed
emolter pushed a commit to emolter/jwst that referenced this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spec2Pipeline turns off NSClean for BOTS
2 participants