-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3515: Spec2Pipeline turns off NSClean for BOTS #8256
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #8256 +/- ##
=======================================
Coverage 75.18% 75.18%
=======================================
Files 470 470
Lines 38549 38549
=======================================
Hits 28983 28983
Misses 9566 9566
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
reg tests running at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1190/ |
Check the documentation for both |
Regtest results are clean. |
1a5a39c
to
7cfd91b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves JP-3515
Closes #8208
This PR addresses adding BOTS data to spec2 modes when skip is False.
Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR