Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3532: MRS 1d residual fringe treatment of negative values #8261

Merged

Conversation

drlaw1558
Copy link
Collaborator

@drlaw1558 drlaw1558 commented Feb 5, 2024

Resolves JP-3532 by properly masking zero or negative-valued spectra instead of only zero-valued spectra.

Closes #8260

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

Copy link
Contributor

@jemorrison jemorrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple fix

@hbushouse hbushouse added this to the Build 10.2 milestone Feb 7, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (557c3fa) 75.18% compared to head (2efa12f) 77.37%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8261      +/-   ##
==========================================
+ Coverage   75.18%   77.37%   +2.18%     
==========================================
  Files         470      451      -19     
  Lines       38549    35270    -3279     
==========================================
- Hits        28983    27290    -1693     
+ Misses       9566     7980    -1586     
Flag Coverage Δ *Carryforward flag
nightly 77.37% <ø> (ø) Carriedforward from 557c3fa

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hbushouse
Copy link
Collaborator

@hbushouse
Copy link
Collaborator

Regtest results are fine. 2 benign (unrelated) failures.

@hbushouse hbushouse merged commit bb57c7e into spacetelescope:master Feb 8, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MRS 1d residual fringe correction zeros out negative fluxes
3 participants