JP-3488 Input files to outlier_detection accidentally deleted

[penaguerrero]

Resolves JP-3488

Closes #8128

This PR addresses unintentional deletion of tweakreg output files when they are used as input to the outlier_detection step.

Checklist for maintainers

• added entry in CHANGES.rst within the relevant release section
• updated or added relevant tests
• updated relevant documentation
• added relevant milestone
• added relevant label(s)
• ran regression tests, post a link to the Jenkins job below.
  How to run regression tests on a PR
• Make sure the JIRA ticket is resolved properly

[tapastro]

This was bad code on my part - the current code expects the model filename to have suffix '_cal' - if any step saves before outlier_detection (or the input has a custom suffix) then the line defining outlr_file will not replace the suffix and just delete the input file. outlr_file should be changed to remove any suffix if present, then add the 'outlier_i2d.fits' suffix to it rather than replace.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (12d4c91) 75.19% compared to head (82026d8) 75.20%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #8263   +/-   ##
=======================================
  Coverage   75.19%   75.20%           
=======================================
  Files         470      470           
  Lines       38580    38581    +1     
=======================================
+ Hits        29012    29013    +1     
  Misses       9568     9568           

Flag	Coverage Δ		*Carryforward flag
nightly	77.38% <ø> (ø)		Carriedforward from db8c48d

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hbushouse]

Looks like this needs a regression test run. Also, has it been tested in the use case originally reported by the user?

[hbushouse]

Still WIP or is it ready to go? If the latter, please update the PR title.

[penaguerrero]

I decided to leave the WIP because I do not have data to test this. I requested it and gave them the branch name to test it themselves but have not heard back

[penaguerrero]

Bryan Hilbert confirmed branch is working as expected. Ready for review.

[hbushouse]

Has a regression test run been executed? I don't see any references/links to it here.

[penaguerrero]

had forgotten about it. Tests running at: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1207/

[hbushouse]

Regression test failures are unrelated (updated ref files and bad test inputs). So this looks good.