-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use tuple of exception classes instead of or
#8267
use tuple of exception classes instead of or
#8267
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #8267 +/- ##
=======================================
Coverage 75.15% 75.15%
=======================================
Files 470 470
Lines 38608 38608
=======================================
Hits 29017 29017
Misses 9591 9591
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update looks OK. Needs a regression test run.
Regression test run started at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1212 |
Regression test run is clean. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me.
This PR addresses an issue brought up by
sonarqube
:https://plsonarqube.stsci.edu/project/issues?resolved=false&inNewCodePeriod=true&types=BUG&branch=fix%2Fcrds&id=spacetelescope-regresstiontests&open=AY2JBrI7z6SXJ5Xq2mK2
Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR