Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use tuple of exception classes instead of or #8267

Merged
merged 4 commits into from
Feb 16, 2024

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Feb 8, 2024

This PR addresses an issue brought up by sonarqube:
https://plsonarqube.stsci.edu/project/issues?resolved=false&inNewCodePeriod=true&types=BUG&branch=fix%2Fcrds&id=spacetelescope-regresstiontests&open=AY2JBrI7z6SXJ5Xq2mK2

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@zacharyburnett zacharyburnett self-assigned this Feb 8, 2024
@github-actions github-actions bot added the photom label Feb 8, 2024
@zacharyburnett zacharyburnett marked this pull request as ready for review February 8, 2024 14:48
@zacharyburnett zacharyburnett requested a review from a team as a code owner February 8, 2024 14:48
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b3f006a) 75.15% compared to head (153eee5) 75.15%.

Files Patch % Lines
jwst/photom/photom.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8267   +/-   ##
=======================================
  Coverage   75.15%   75.15%           
=======================================
  Files         470      470           
  Lines       38608    38608           
=======================================
  Hits        29017    29017           
  Misses       9591     9591           
Flag Coverage Δ *Carryforward flag
nightly 77.38% <ø> (ø) Carriedforward from b3f006a

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hbushouse hbushouse added this to the Build 10.2 milestone Feb 13, 2024
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update looks OK. Needs a regression test run.

@hbushouse
Copy link
Collaborator

@hbushouse
Copy link
Collaborator

Regression test run is clean.

Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@hbushouse hbushouse merged commit 731ac25 into spacetelescope:master Feb 16, 2024
28 of 29 checks passed
@zacharyburnett zacharyburnett deleted the fix/sonarqube branch February 22, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants