JP-2090: Update set_velocity_aberration to use DataModel

[emolter]

Resolves JP-2090

Closes #6053

This PR addresses updating the set_velocity_aberration script to use DataModels instead of fits for opening and manipulating data.

Checklist for maintainers

• added entry in CHANGES.rst within the relevant release section
• updated or added relevant tests
• updated relevant documentation
• added relevant milestone
• added relevant label(s)
• ran regression tests, post a link to the Jenkins job below.
  How to run regression tests on a PR
• Make sure the JIRA ticket is resolved properly

[codecov]

Codecov Report

Attention: Patch coverage is 94.44444% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 75.37%. Comparing base (4cc0ac1) to head (2e60ee3).
Report is 15 commits behind head on master.

❗ Current head 2e60ee3 differs from pull request most recent head f35c4e2. Consider uploading reports for the commit f35c4e2 to get more accurate results

Files	Patch %	Lines
jwst/lib/set_velocity_aberration.py	90.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8285      +/-   ##
==========================================
+ Coverage   75.15%   75.37%   +0.21%     
==========================================
  Files         470      474       +4     
  Lines       38604    38921     +317     
==========================================
+ Hits        29014    29337     +323     
+ Misses       9590     9584       -6     

Flag	Coverage Δ		*Carryforward flag
nightly	77.33% <ø> (-0.06%)	⬇️	Carriedforward from 12b7c94

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hbushouse]

Did you do a regression test run? I'm not sure we have any tests that cover this script, but it can't hurt.

[emolter]

Did you do a regression test run? I'm not sure we have any tests that cover this script, but it can't hurt.

I did not - the test coverage is inside lib/tests/test_velocity_aberration.py. I will do a regression test run anyway, though

[emolter]

started this Jenkins run

[hbushouse]

These code updates look fine. But before we approve and merge, I'm doing some research into JP-896, which suggests we might need/want to add another fix to this script, in order to have it use velocity information in the proper reference frame. That ticket suggests that these calculations should be using velocities that are in the heliocentric frame, but the keyword values we're using are actually in the Earth-centered frame. I'm trying to track down exactly what's going on with all of that.

[hbushouse]

Regression test run results are clean and JP-896 has been verified to no longer be an issue (fixed long ago in DMS build 7.8), so no further updates are needed to fix any old issues in this PR.