-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3463: Add average_dark_current handling to dark_current step #8302
JP-3463: Add average_dark_current handling to dark_current step #8302
Conversation
78e86c8
to
fae2f7e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8302 +/- ##
===========================================
- Coverage 75.15% 53.15% -22.01%
===========================================
Files 470 389 -81
Lines 38604 38442 -162
===========================================
- Hits 29014 20434 -8580
- Misses 9590 18008 +8418
☔ View full report in Codecov by Sentry. |
85b747f
to
4208c28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code updates look good. Just a couple questions about the new unit test.
@tapastro If you can address my couple of review questions I'd be willing to approve. Unless you think it needs more work. |
I just need to spend some time determining if that test provides any useful coverage, or if I should get another regression test parametrization in that sets the dark current to ensure it's doing someting. I'll work on better testing and get back to you next week. |
ea3f13f
to
3f4931f
Compare
Regression tests here: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1301/ I added a test to ensure data is tested with a non-zero average dark current specified. This test can be removed if/when darks are delivered with non-zero values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just found one small typo in docs
Co-authored-by: Ned Molter <emolter@users.noreply.github.com>
The 1301 regtest run shows only the expected differences in products created during Detector1 processing (before ramp fitting), which now contain either the extra "AVDRKCUR" image extension or the new "AVDRKCUR" keyword. So that looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay, the docs have build correctly and the regtest results look good. I hereby approve this PR.
I have to say I'm a little sad the message for this commit didn't make it into main due to the squash :) |
Resolves JP-3463
Closes #8071
This PR adds pipeline handling of new datamodel quantities for the average dark current. This can be specified either by the user, as a scalar quantity, or in the dark reference file, as a scalar quantity or a 2D array matching the dark reference file size. If the user provides a value, it will override any dark reference value. If a user wishes to provide a 2D array, it will be left to them to generate a custom dark.
This quantity has been/wiill be added to the RampModel in spacetelescope/stdatamodels#265; it will be stored in the RampModel for use in the ramp_fitting step.
NOTE: This PR is labelled WIP until the stdatamodels PR linked above is merged.
Checklist for maintainers
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR