JP-3562: Extend snowball core

[mwregan2]

This PR addresses the need to add two new parameters for the Jump step that control the flagging of cores of snowballs in the next integration.
The two parameters exist in the STCAL code and just need an external interface

Checklist for maintainers

• added entry in CHANGES.rst within the relevant release section
• updated or added relevant tests
• updated relevant documentation
• added relevant milestone
• added relevant label(s)
• ran regression tests, post a link to the Jenkins job below.
  How to run regression tests on a PR
• Make sure the JIRA ticket is resolved properly

[hbushouse]

Updates to the algorithms in stcal contained in spacetelescope/stcal#248

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.23%. Comparing base (2fb073e) to head (cacbb30).
Report is 7 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8303      +/-   ##
==========================================
- Coverage   75.31%   75.23%   -0.08%     
==========================================
  Files         474      474              
  Lines       38965    39000      +35     
==========================================
- Hits        29345    29343       -2     
- Misses       9620     9657      +37     

Flag	Coverage Δ		*Carryforward flag
nightly	77.33% <ø> (-0.01%)	⬇️	Carriedforward from 72e4dfa

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hbushouse]

regtest run started at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1343

[emolter]

Regression test failures with errors failed on setup with "IndexError: list index out of range" and stpipe.config_parser.ValidationError: Config parameter 'snowball_time_masked_next_int(default': missing were probably caused by the one typo in the spec string.

It looks like these account for all regtest failures except one, an assertion error in lib.tests.test_suffix.[stable-deps] test_suffix_existence . I didn't look deeply into what this test is for, but it would be good to look into that one a bit more

It also looks like some unit tests might need to be checked. There are some failing tests with TypeError: detect_jumps() got an unexpected keyword argument 'min_diffs_single_pass'

[hbushouse]

Yet another regtest run started after fixing all the typos in the code: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1345

[nden]

While looking at the spec I noticed use_ellipses has a comment it was deprecated. As far as I can tell it's not used in the stcal code any more. However, the deprecation is only visible to those that read comments on parameters. It needs to be deprecated in the code properly before being removed.

[hbushouse]

FINALLY got a complete regtest run at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1347/ which shows the same 2 failures as the most recent run against master and are unrelated. So this looks clean.

[hbushouse]

The continued failures in the CI tests are due to them using the released version of stcal, which doesn't yet have the corresponding updates needed by this PR.

[hbushouse]

I'm incorporating review comments about argument names and descriptions

[hbushouse]

While looking at the spec I noticed use_ellipses has a comment it was deprecated. As far as I can tell it's not used in the stcal code any more. However, the deprecation is only visible to those that read comments on parameters. It needs to be deprecated in the code properly before being removed.

If it's OK with you, I'd like to merge this as is, now that code at least runs and the argument names have been cleaned up a bit. We can then do another PR to deprecate use_ellipses later.

[hbushouse]

Final regtest run at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1349/ Only 2 unrelated failures. This looks clean.