Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3423: fixed array shape mismatch in pixel_replace mingrad algorithm #8312

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

emolter
Copy link
Collaborator

@emolter emolter commented Feb 27, 2024

Resolves JP-3423

Closes #7960

This PR addresses a bug that would cause crashes when the mingrad algorithm for pixel replacement was applied to NIRSpec data. The error was due to an inappropriate assumption about the input array shape, which was fixed in a single line.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 75.21%. Comparing base (4cc0ac1) to head (96d47d4).
Report is 7 commits behind head on master.

Files Patch % Lines
jwst/pixel_replace/pixel_replace.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8312      +/-   ##
==========================================
+ Coverage   75.15%   75.21%   +0.05%     
==========================================
  Files         470      474       +4     
  Lines       38604    38810     +206     
==========================================
+ Hits        29014    29192     +178     
- Misses       9590     9618      +28     
Flag Coverage Δ *Carryforward flag
nightly 77.37% <ø> (-0.03%) ⬇️ Carriedforward from 75645eb

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emolter emolter marked this pull request as ready for review February 27, 2024 17:04
@emolter emolter requested a review from a team as a code owner February 27, 2024 17:04
@hbushouse hbushouse added this to the Build 10.2 milestone Feb 28, 2024
@hbushouse
Copy link
Collaborator

@emolter Looks like this needs a regression test run.

@emolter
Copy link
Collaborator Author

emolter commented Feb 28, 2024

Just started this one, sorry about that:

regtest run

edit: all tests passed

Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change is fine and regtest run is clean.

@hbushouse hbushouse merged commit 53bfbc6 into spacetelescope:master Feb 29, 2024
29 of 30 checks passed
@emolter emolter deleted the JP-3423 branch February 29, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mingrad algorithm crashes pixel_replace for NIRSpec data
2 participants