Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3541: fixed tweakreg step KeyError due to empty gaia catalog #8334

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

emolter
Copy link
Collaborator

@emolter emolter commented Mar 6, 2024

Resolves JP-3541

Closes #8286

This PR addresses a bug that caused tweakreg to fail when the bounding box of the input image was too small to find any sources in the GAIA catalog. This PR ensures that the appropriate warning (Not enough sources (0) in the reference catalog...), which was already implemented, is hit instead, and the step completes successfully.

Regression test run here.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@emolter emolter marked this pull request as ready for review March 6, 2024 21:58
@emolter emolter requested a review from a team as a code owner March 6, 2024 21:58
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.38%. Comparing base (4cc0ac1) to head (cbf3d78).
Report is 17 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8334      +/-   ##
==========================================
+ Coverage   75.15%   75.38%   +0.22%     
==========================================
  Files         470      474       +4     
  Lines       38604    38939     +335     
==========================================
+ Hits        29014    29353     +339     
+ Misses       9590     9586       -4     
Flag Coverage Δ *Carryforward flag
nightly 77.33% <ø> (-0.07%) ⬇️ Carriedforward from 4cc0ac1

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hbushouse hbushouse added this to the Build 10.2 milestone Mar 11, 2024
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one minor question.

jwst/tweakreg/astrometric_utils.py Show resolved Hide resolved
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hbushouse hbushouse merged commit 5ca492c into spacetelescope:master Mar 12, 2024
29 checks passed
@emolter emolter deleted the JP-3541 branch March 12, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

level3 nis_image of jw01230-o009_20240210t011656_image3_00001 crashed with KeyError: 'ra'
2 participants