Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JP-3445: Exclude NINTS=1 from SOSS TSO3 associations #8359

Merged
merged 5 commits into from
Mar 15, 2024

Conversation

hbushouse
Copy link
Collaborator

@hbushouse hbushouse commented Mar 13, 2024

Resolves JP-3445

Closes #8027

This PR updates the Level-3 ASN rules for forming "tso3" type associations, so that NIRISS SOSS "dummy" exposures that have NINTS=1 are excluded from the association. They aren't desired to be part of the level-3 processing and cause an abort in the tso3 pipeline if they appear in the ASN.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@hbushouse
Copy link
Collaborator Author

Test results using the pool from program jw03596 show that the tso3 asn for observation 001 no longer contain the exposure "jw03596001001_03101_00001-seg001_nis_calints.fits", which is the "dummy" exposure that uses NINTS=1 and was causing the tso3 pipeline to abort.

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.31%. Comparing base (4cc0ac1) to head (136137f).
Report is 28 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8359      +/-   ##
==========================================
+ Coverage   75.15%   75.31%   +0.15%     
==========================================
  Files         470      474       +4     
  Lines       38604    38965     +361     
==========================================
+ Hits        29014    29346     +332     
- Misses       9590     9619      +29     
Flag Coverage Δ *Carryforward flag
nightly 77.33% <ø> (-0.07%) ⬇️ Carriedforward from eb3473c

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hbushouse
Copy link
Collaborator Author

Regression test run started at https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1315

Note that a new pool and related output asn files have been added to the asn regression tests on Artifactory. The new pool comes from the 3596 program that was causing the original trouble. It contains the additional "NINTS" column that SDP will now be adding to all pool files.

@hbushouse
Copy link
Collaborator Author

All 53 regression test failures are unrelated and due to a recent update to a datamodels schema. So this PR has clean results.

@tapastro tapastro merged commit 77c4966 into spacetelescope:master Mar 15, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

level_3 (tso3) nis_soss calibration aborted with "data not tso mode"
3 participants