Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tophat kernel as an available option for resample kernel #8364

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

mcara
Copy link
Member

@mcara mcara commented Mar 14, 2024

This PR removes the tophat option for the kernel which was deprecated in the drizzle package and it will be removed in the next release of the drizzle.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

Regression test: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/1312

@mcara mcara added this to the Build 10.2 milestone Mar 14, 2024
@mcara mcara requested review from nden and hbushouse March 14, 2024 06:26
@mcara mcara self-assigned this Mar 14, 2024
@mcara mcara requested a review from a team as a code owner March 14, 2024 06:26
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hbushouse hbushouse merged commit ebe9894 into spacetelescope:master Mar 14, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants